Move params implementation to new file #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I was also thinking about renaming the files |
f1b2868 to
94f30dd
Compare
Codecov Report
@@ Coverage Diff @@
## master #784 +/- ##
==========================================
+ Coverage 70.57% 70.72% +0.14%
==========================================
Files 144 145 +1
Lines 19214 19208 -6
==========================================
+ Hits 13560 13584 +24
+ Misses 5654 5624 -30
Continue to review full report at Codecov.
|
D4N
reviewed
Apr 22, 2019
Member
Sorry, missed this comment: no objections from my side, I'm all in for more clarity. |
b50ff89 to
1894d9b
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I am proposing to move the implementation of Params's methods to its own .cpp file.
I started these changes just with the idea of implementing the existing Singleton in Params in the modern c++ way (see first commit). Then I realised that most of the file
exiv2.cppwas the implementation of that Params class and I think it would be better to have it on its own file. Thanks to this change, now theexiv2.cppfile only has 90 LoC.I recommend to review the PR commit by commit since I also took the opportunity to clang-format the exiv2app.* files.